Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "CategoricalArrays" to "0.7" #1348

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the CategoricalArrays package from 0.5 to 0.5, 0.7.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@bjarthur
Copy link
Member

@CiaranOMara do you know why travis ran twice on this PR? on is labelled "pr" the other "push".

@codecov-io
Copy link

Codecov Report

Merging #1348 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1348   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          36       36           
  Lines        3940     3940           
=======================================
  Hits         3551     3551           
  Misses        389      389

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4abe78...95ff238. Read the comment docs.

@Mattriks Mattriks mentioned this pull request Nov 16, 2019
5 tasks
@CiaranOMara
Copy link
Contributor

CiaranOMara commented Nov 16, 2019

I'm gonna have to check out this CompatHelper for myself.

The pr hook is the "continuous integration branch protection" that is enabled on the github side; it does a build/test of the merge of the head branch with the base branch specified in the pull request.

The push hook is enabled on the Travis side with the "build pushed branches" setting; it does a build/test of the branch head. A whitelist/blacklist of branches can be set in the travis.yaml. I think adding the following to the travis.yaml would remove unnecessary CompatHelper builds/tests triggered by the push hook.

branches:
  except:
  - /^compathelper.*$/ 

@bjarthur bjarthur merged commit 2816ba5 into master Nov 17, 2019
@bjarthur bjarthur deleted the compathelper/new_version/2019-11-16-19-04-40-055-2704968666 branch November 17, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants