-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Update #1340
CI Update #1340
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1340 +/- ##
=========================================
Coverage ? 90.12%
=========================================
Files ? 36
Lines ? 3940
Branches ? 0
=========================================
Hits ? 3551
Misses ? 389
Partials ? 0 Continue to review full report at Codecov.
|
34170ca
to
45a0eb4
Compare
I wasn't sure how to best structure this pull request. Anyhow, I've added Cairo.jl compatibility changes on the back of this PR as it not only shows improvement across operating systems, it also shows how the Edge stage works - you'll notice that many of the deprecation warnings are already addressed by Compose.jl#master. |
I assume this PR will close #1320 and #1324. If so, add that to your first post above (https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords) |
it'd be better to have the Cairo dependency commit in a separate PR. i'd merge that right away. regarding 1.3, again, i'd suggest holding off on that until it is actually released, and stop testing on 1.2 at the same time. i also don't understand the Edge job. i'm just being dumb here i think. can you please explain how this is different? |
Previously, by way of the |
a1dbb95
to
45a0eb4
Compare
I have moved the Cairo compatibility change to #1343. |
9e982cc
to
6eea953
Compare
I have removed Julia v1.3 from the test matrix. |
6eea953
to
a8552ba
Compare
The Edge stage does not seem quite right as it does not appear to be allowed to fail. |
37a9560
to
3b34572
Compare
This pull request was created in response to #1339 (comment).
Proposed changes
Add Julia 1.3 to test matrix.Moving tests using Compose.jl#master into their own stage provides visibility for new development while prioritising Gadfly.jl#master.