Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Update #1340

Closed
wants to merge 3 commits into from
Closed

Conversation

CiaranOMara
Copy link
Contributor

@CiaranOMara CiaranOMara commented Nov 6, 2019

This pull request was created in response to #1339 (comment).

Proposed changes

  • Add Julia 1.3 to test matrix.
  • Use the codecov flag in Travis instead of the manual code version.
  • Pkg.instantiate after Pkg.develop.
  • Add colour to make doc output.
  • Move tests with Compose.jl#master into an Edge stage.

Moving tests using Compose.jl#master into their own stage provides visibility for new development while prioritising Gadfly.jl#master.

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6d68260). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1340   +/-   ##
=========================================
  Coverage          ?   90.12%           
=========================================
  Files             ?       36           
  Lines             ?     3940           
  Branches          ?        0           
=========================================
  Hits              ?     3551           
  Misses            ?      389           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d68260...3b34572. Read the comment docs.

@CiaranOMara CiaranOMara changed the title Fiddle with Travis CI Update Nov 6, 2019
@CiaranOMara CiaranOMara force-pushed the feature/travis branch 5 times, most recently from 34170ca to 45a0eb4 Compare November 7, 2019 03:46
@CiaranOMara CiaranOMara closed this Nov 7, 2019
@CiaranOMara CiaranOMara deleted the feature/travis branch November 7, 2019 11:59
@CiaranOMara CiaranOMara restored the feature/travis branch November 7, 2019 12:00
@CiaranOMara CiaranOMara reopened this Nov 7, 2019
@CiaranOMara
Copy link
Contributor Author

CiaranOMara commented Nov 8, 2019

I wasn't sure how to best structure this pull request. Anyhow, I've added Cairo.jl compatibility changes on the back of this PR as it not only shows improvement across operating systems, it also shows how the Edge stage works - you'll notice that many of the deprecation warnings are already addressed by Compose.jl#master.

@Mattriks
Copy link
Member

Mattriks commented Nov 8, 2019

I assume this PR will close #1320 and #1324. If so, add that to your first post above (https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords)

@bjarthur
Copy link
Member

bjarthur commented Nov 9, 2019

it'd be better to have the Cairo dependency commit in a separate PR. i'd merge that right away.

regarding 1.3, again, i'd suggest holding off on that until it is actually released, and stop testing on 1.2 at the same time.

i also don't understand the Edge job. i'm just being dumb here i think. can you please explain how this is different?

@CiaranOMara
Copy link
Contributor Author

Previously, by way of the before_script, all tests were performed using Compose.jl#master. With this PR, tests in the Test job use a Compose.jl release and tests in the Edge job use Compose.jl#master. With this configuration, the tests in the Test job test the packages installed by the end-user, and the tests in the Edge job shows developers how Gadfly.jl is performing with the latest Compose.jl developments.

@CiaranOMara
Copy link
Contributor Author

I have moved the Cairo compatibility change to #1343.

@CiaranOMara
Copy link
Contributor Author

I have removed Julia v1.3 from the test matrix.

.travis.yml Outdated Show resolved Hide resolved
@CiaranOMara
Copy link
Contributor Author

The Edge stage does not seem quite right as it does not appear to be allowed to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants