Update MIME type for show

[jjerphan]

Fixes #1316

Contributor checklist:

• I've updated the documentation to reflect these changes: no change required
• I've added an entry to NEWS.md
• I've added and/or updated the unit tests: no need to.
• I've run the regression tests: all the passing test on master pass on this branch
• I've squash'ed or fixup'ed junk commits with git-rebase: one commit PR
• I've built the docs and confirmed these changes don't cause new errors

Proposed changes

• Resolves the deprecation

[tlnagy]

Thanks for the PR! Do you have a reference for when this change was made in Juno? It would be best to put a lower bound in the [compat] section of Project.toml for this change

[jjerphan]

@tlnagy: I don't know at all, I'll try to find it in Juno's history. :)

[jjerphan]

It comes from this commit in Atom.jl.

It seems that v0.7.9 is the lower bound — I don't know whether I should add Atom in Project.toml or find the appropriate version of Juno that uses this version of Atom.

[tlnagy]

Please don't add Atom.jl to Project.toml.

find the appropriate version of Juno that uses this version of Atom.

This is the correct way. If compatible Juno versions don't have a hard lower bound against the Atom, I would file an issue with them since this would need to get fixed on their end.

[jjerphan]

It looks like it's Atom.jl that depends on Juno.jl — see here

[bjarthur]

@jjerphan thanks for taking the time to submit this PR!

i would suggest keeping both methods, so that Gadfly support both old and new versions of Atom. so make a Union of those mime types: m::Union{MIME"application/juno+plotpane, MIME"application/prs.juno.plotpane+html"}"

[codecov-io]

Codecov Report

Merging #1322 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
- Coverage    90.1%   90.02%   -0.09%     
==========================================
  Files          36       36              
  Lines        3953     3941      -12     
==========================================
- Hits         3562     3548      -14     
- Misses        391      393       +2

Impacted Files	Coverage Δ
src/Gadfly.jl	77.58% <ø> (-1.01%)	⬇️
src/theme.jl	69.49% <0%> (-1.7%)	⬇️
src/mapping.jl	84.46% <0%> (-0.98%)	⬇️
src/geom/errorbar.jl	92.3% <0%> (+0.41%)	⬆️
src/dataframes.jl	97.43% <0%> (+6.86%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eed988...8132ee4. Read the comment docs.

[jjerphan]

@bjarthur: I've performed this latter small change.

@tlnagy: just a little follow up on my last comment: what should be done regarding the compatibility with Atom.jl?

[bjarthur]

i don't think anything needs to be done with [compat]. think this is fine as is and ready to go.

@tlnagy shall we merge? just need to squash the two commits when we do.

[tlnagy]

Agreed.