Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat.histogram(limits=()) #1249

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Feb 5, 2019

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

Example

using DataFrames, Distributions
gamma, beta = Gamma(2,2), Beta(2,2)
D = DataFrame(x1=rand(gamma, 10^4), x2=rand(beta,10^4))
layerf(dist, max) = layer(x->pdf(dist, x), 0, max, Geom.line, Theme(default_color="black"))

p1 = plot(D,  Coord.cartesian(xmin=0, xmax=20), layerf(gamma, 20),
    layer(x=:x1, Geom.histogram(bincount=20, density=true, limits=(min=0,))) )
p2 = plot(D, layerf(beta, 1),
    layer(x=:x2, Geom.histogram(bincount=20, density=true, limits=(min=0,max=1))) )

hstack(p1, p2)

hist_limits

@codecov-io
Copy link

Codecov Report

Merging #1249 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   85.72%   85.75%   +0.03%     
==========================================
  Files          35       35              
  Lines        4118     4120       +2     
==========================================
+ Hits         3530     3533       +3     
+ Misses        588      587       -1
Impacted Files Coverage Δ
src/geom/bar.jl 91.85% <ø> (ø) ⬆️
src/statistics.jl 90.62% <100%> (+0.01%) ⬆️
src/poetry.jl 88.88% <0%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13cf145...1ea3306. Read the comment docs.

@bjarthur bjarthur merged commit e2376e4 into GiovineItalia:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose range in Geom.histogram
3 participants