Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stat.histogram update #1236

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Stat.histogram update #1236

merged 1 commit into from
Jan 3, 2019

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Jan 3, 2019

  • I've updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR:

Examples

# from #1163
x_cont = [1,1,1,1,1,2,2,2,2]
x_disc = string.(x_cont)
p1 = plot(x=x_cont, Geom.histogram(density=true))
p2 = plot(x=x_disc, Geom.histogram(density=true))
hstack(p1, p2)

iss1235a

# from #1235 
df = DataFrame(Num_digits=[1,1,1,1,1,2,2,2,2,2,2],
    Primality=[false,true,true,false,false,false,true,false,false,false,true])
p3 = plot(df, x=:Num_digits, Geom.histogram(position=:stack), Scale.x_discrete, color=:Primality)
p4 = plot(df, x=:Num_digits, Geom.histogram(position=:dodge), Scale.x_discrete, color=:Primality)
hstack(p3, p4)

iss1235b

@codecov-io
Copy link

Codecov Report

Merging #1236 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1236      +/-   ##
==========================================
+ Coverage   85.37%   85.45%   +0.07%     
==========================================
  Files          35       35              
  Lines        4096     4083      -13     
==========================================
- Hits         3497     3489       -8     
+ Misses        599      594       -5
Impacted Files Coverage Δ
src/statistics.jl 89.78% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0925f...c63ee21. Read the comment docs.

@bjarthur bjarthur merged commit 991b6dd into GiovineItalia:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram binning issue? histogram(density = true) and x_discrete(labels = ...) incompatible ?
3 participants