Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure in discretize_make_ia #1193

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

nalimilan
Copy link
Contributor

This PR is just to test a few possibles fixes/workarounds for the failure at #1189.

@bjarthur
Copy link
Member

thanks for looking into this!

@nalimilan nalimilan changed the title WIP: Attempt to fix test failure in discretize_make_ia Fix test failure in discretize_make_ia Sep 14, 2018
@nalimilan
Copy link
Contributor Author

Actually it turns out this was trivial. I have no idea why I haven't realized the missing something call before, I could have sweared it was present.

There's a problem when trying to build docs, maybe related to the use of SubString? Can be fixed later anyway.

@bjarthur bjarthur merged commit e55dee9 into GiovineItalia:master Sep 14, 2018
@nalimilan nalimilan deleted the patch-1 branch September 14, 2018 14:12
@tlnagy tlnagy mentioned this pull request Sep 14, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants