Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes #1129

Merged
merged 6 commits into from
Apr 4, 2018
Merged

Some minor fixes #1129

merged 6 commits into from
Apr 4, 2018

Conversation

andreasnoack
Copy link
Contributor

This should fix #1125 by handle levels and order arguments correctly in Scale. I've added some the examples from #1125 to ensure that this doesn't break again.

@codecov-io
Copy link

codecov-io commented Apr 4, 2018

Codecov Report

Merging #1129 into master will increase coverage by 0.46%.
The diff coverage is 80.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
+ Coverage   86.09%   86.56%   +0.46%     
==========================================
  Files          32       32              
  Lines        3970     3959      -11     
==========================================
+ Hits         3418     3427       +9     
+ Misses        552      532      -20
Impacted Files Coverage Δ
src/geometry.jl 71.42% <ø> (ø) ⬆️
src/aesthetics.jl 83.19% <100%> (+0.43%) ⬆️
src/scale.jl 89.28% <100%> (+7.53%) ⬆️
src/geom/ribbon.jl 100% <100%> (ø) ⬆️
src/geom/line.jl 90.21% <100%> (ø) ⬆️
src/geom/boxplot.jl 100% <100%> (ø) ⬆️
src/geom/beeswarm.jl 91.35% <100%> (ø) ⬆️
src/geom/errorbar.jl 97.29% <100%> (ø) ⬆️
src/geom/rectbin.jl 77.77% <100%> (ø) ⬆️
src/geom/polygon.jl 66.66% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36d55c...a23d4b3. Read the comment docs.

Copy link
Member

@tlnagy tlnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are minor changes and they fix master so I think we should go ahead and merge.

@tlnagy tlnagy merged commit 602f2d6 into GiovineItalia:master Apr 4, 2018
@tlnagy
Copy link
Member

tlnagy commented Apr 4, 2018

Looks like RDatasets is dumping a bunch of deprecations due to JuliaData/CSV.jl#173. I have a fix for it at JuliaStats/RDatasets.jl#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken example in docs
3 participants