-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor fixes #1129
Some minor fixes #1129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
==========================================
+ Coverage 86.09% 86.56% +0.46%
==========================================
Files 32 32
Lines 3970 3959 -11
==========================================
+ Hits 3418 3427 +9
+ Misses 552 532 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are minor changes and they fix master so I think we should go ahead and merge.
Looks like |
This should fix #1125 by handle
levels
andorder
arguments correctly inScale
. I've added some the examples from #1125 to ensure that this doesn't break again.