-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PkgEval] Gadfly may have a testing issue on Julia 0.4 (2014-08-30) #409
Comments
I guess this just has to be updated for 0.4.0. It is useful to have a compatible version for 0.3.x as well. |
:cries: Would love to have a gadfly that can at least be loaded under 0.4. |
@Keno just fixed the equivalent in TexExtensions, it could be ported to Gadfly (or even into Base?) |
I'd do it but no time for next few days |
Would be good to have @quinnj check this over, however; TexExtensions doesn't have any "real" tests (I just added one that checks whether the package loads), and I confess I was more interested in fixing the Images->SIUnits->TexExtensions load dependency chain than in getting the right answer 😄. |
+10 for exposing a richer number formatting API that would have made direct use of grisu unnecessary. I've always felt there should be a good way to do formatting without making printf format strings or calling un-exported functions. |
I was actually just thinking about / working on this today. There's certainly much better that can be done. |
Yes, I've been thinking about this too. The problem is I haven't really wanted to replace the
Which just mirrors the grisu API overall. |
I don't think that's going to make people especially happy unless it also includes a lot of controls for doing printf-like formatting when calling those. |
I guess I'm not sure what you have in mind that's non-overlapping with |
Jeff is unsatisfied with printf ;-) |
Got it. Well, feel free to throw up an issue with ideas or sketches and I can chime in on molding grisu if needed. I have a few ideas on JuliaLang/julia#6608 that I need to play around with in the mean time. |
Any update on getting Gadfly to run under 0.4? |
What needs to be updated is the use of dates and grisu. Gadfly calls both of those just to format values nicely. That formatting code should be removed from Gadfly and put either in Base or a separate package. The abstraction I need is basically “format n values consistently and with sufficient precision”. I imagine that must be useful elsewhere (e.g. printing arrays or data frames with user-defined types), and it would really improve the situation with plotting non-number types in gadfly: if labels are messed up, it's the responsibility of whoever defined the type to write a reasonable format function. |
But to actually answer your question: it doesn't work yet, but I want to actually take the time to do the formatting thing right this time rather than patch over it. |
I've made some updates and on julia 0.4, Gadfly will now randomly, and with about equal probability, either work perfectly, segfault, or throw a |
Just tried it after removing completely my |
Oh, I haven't tagged a new version yet. I wanted to figure out the weird errors first. But you can try it on master. |
I cloned Gadfly and Showoff, but got again the same grisu error, will try again tomorrow though (as I will be away from the laptop for the next few hours). |
P.S. This is what I get:
|
I see, I had uncommitted changes in Showoff. Now it should work. |
Hurrah, it works! No grisu error anymore nor Date/datetime errors (in relation to #401), Gadfly opened its wings again. |
Hi, I am using Julia Version 0.4.0-dev+734 (2014-09-23 18:22 UTC) in a Debian GNU/Linux. I just tried to use Gadfly in the way you suggested here and I found the same error in grisu_ccall: 1)- I removed my folder .julia julia> using Gadfly Any other idea? Thanks for your attention, Charles |
@cndesantana There has probably not been tagged a new version of Gadfly yet. You will have to do ```julia
So that you get back to using tagged versions. |
Exactly this, @dcjones! ;) Thank you for your help! It is working perfectly now! :) I did: julia> Pkg.checkout("Gadfly") julia> Pkg.checkout("Showoff") julia> using Gadfly Best, Charles From: Ivar Nesje [[email protected]] @cndesantanahttps://github.com/cndesantana There has probably not been tagged a new version of Gadfly yet. You will have to do ```julia to use the master branch. Not sure if more dependencies needs to be on the master branch. When this is fixed and versions gets tagged again, you should do Pkg.free("Gadfly")
Pkg.free("Showoff")
So that you get back to using tagged versions.
—
Reply to this email directly or view it on GitHub<https://github.com/dcjones/Gadfly.jl/issues/409#issuecomment-56643684>. |
The latest tagged version supports julia 0.4 for now. |
PackageEvaluator.jl is a script that runs nightly. It attempts to load all Julia packages and run their tests (if available) on both the stable version of Julia (0.3) and the nightly build of the unstable version (0.4). The results of this script are used to generate a package listing enhanced with testing results.
On Julia 0.4
Tests pass.
Package doesn't load.
Tests pass.
means that PackageEvaluator found the tests for your package, executed them, and they all passed.Package doesn't load.
means that PackageEvaluator did not find tests for your package. Additionally, trying to load your package withusing
failed.This issue was filed because your testing status became worse. No additional issues will be filed if your package remains in this state, and no issue will be filed if it improves. If you'd like to opt-out of these status-change messages, reply to this message saying you'd like to and @IainNZ will add an exception. If you'd like to discuss PackageEvaluator.jl please file an issue at the repository. For example, your package may be untestable on the test machine due to a dependency - an exception can be added.
Test log:
The text was updated successfully, but these errors were encountered: