Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency versions? #1287

Closed
tlnagy opened this issue Jun 2, 2019 · 3 comments · Fixed by #1288
Closed

Relax dependency versions? #1287

tlnagy opened this issue Jun 2, 2019 · 3 comments · Fixed by #1288

Comments

@tlnagy
Copy link
Member

tlnagy commented Jun 2, 2019

I'm stuck on a broken version of Distributions because Gadfly's dependencies are a little too restrictive as of #1283. My understanding is that currently the max allowed version of Distributions is v0.19.1 even though v0.20.0 is out and fixes my problem and it's due to the hard caps in the [compat] section of Project.toml

Distributions = "0.16, 0.17, 0.18, 0.19"

I suspect we want to use inequalitys instead of the default caret values: https://julialang.github.io/Pkg.jl/dev/compatibility/#Inequality-specifiers-1

@Mattriks
Copy link
Member

Mattriks commented Jun 2, 2019

Related: JuliaRegistries/General#647

@bjarthur
Copy link
Member

bjarthur commented Jun 3, 2019

if Gadfly's tests work for you with Distributions 0.20, then submit a PR to Gadfly which adds that version to the compat section of Project.toml. @non-Jedi made a convincing argument (to me) that we shouldn't leave the version bounds open ended.

@tlnagy
Copy link
Member Author

tlnagy commented Jun 3, 2019

@non-Jedi made a convincing argument (to me) that we shouldn't leave the version bounds open ended.

That argument makes sense. Alright, let me run the tests and see how they perform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants