Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the TagBot configuration #415

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Update the TagBot configuration #415

merged 2 commits into from
Jan 30, 2021

Conversation

DilumAluthge
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Jan 30, 2021

Codecov Report

Merging #415 (b4ffb4a) into master (adcf670) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   44.14%   44.11%   -0.03%     
==========================================
  Files          18       18              
  Lines        3391     3391              
==========================================
- Hits         1497     1496       -1     
- Misses       1894     1895       +1     
Impacted Files Coverage Δ
src/cairo_backends.jl 59.72% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adcf670...c1c777b. Read the comment docs.

@DilumAluthge
Copy link
Contributor Author

It will be good to merge this ASAP.

@DilumAluthge
Copy link
Contributor Author

Also cc: @bjarthur

@bjarthur bjarthur merged commit 993951f into GiovineItalia:master Jan 30, 2021
@bjarthur
Copy link
Member

thanks! mind doing this for Gadfly.jl as well?

@DilumAluthge DilumAluthge deleted the patch-1 branch January 30, 2021 20:54
@DilumAluthge
Copy link
Contributor Author

@bjarthur
Copy link
Member

bjarthur commented Feb 7, 2021

@DilumAluthge i just noticed you commented out ssh: ${{ secrets.DOCUMENTER_KEY }} in this PR. what was the reason for doing so? thanks.

@DilumAluthge
Copy link
Contributor Author

DilumAluthge commented Feb 7, 2021

Oops that was accidental. You should uncomment it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants