Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to using hex for fill colors instead of RGBA #324

Merged
merged 2 commits into from
Nov 28, 2018

Conversation

tlnagy
Copy link
Member

@tlnagy tlnagy commented Oct 28, 2018

2nd part of #322

@codecov-io
Copy link

codecov-io commented Oct 28, 2018

Codecov Report

Merging #324 into master will decrease coverage by 48.13%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #324       +/-   ##
==========================================
- Coverage   79.44%   31.3%   -48.14%     
==========================================
  Files          14      18        +4     
  Lines        1192    3031     +1839     
==========================================
+ Hits          947     949        +2     
- Misses        245    2082     +1837
Impacted Files Coverage Δ
src/property.jl 20.25% <ø> (-79.75%) ⬇️
src/svg.jl 60.09% <71.42%> (-18.6%) ⬇️
src/Compose.jl 10.12% <0%> (-89.88%) ⬇️
src/table.jl 9.52% <0%> (-84.6%) ⬇️
src/list.jl 19.23% <0%> (-80.77%) ⬇️
src/misc.jl 29.62% <0%> (-54.59%) ⬇️
src/form.jl 44.18% <0%> (-52.76%) ⬇️
src/measure.jl 24.76% <0%> (-51.71%) ⬇️
src/cairo_backends.jl 36.25% <0%> (-46.02%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb9b07...391859c. Read the comment docs.

@bjarthur
Copy link
Member

bump

@bjarthur bjarthur mentioned this pull request Nov 20, 2018
@bjarthur
Copy link
Member

is this ready to merge? or is it stale?

@Mattriks
Copy link
Member

The function svgalphatest needs to be added to this PR. See this post and the subsequent posts. If you merge this PR, I can add svgalphatest in another PR?

@tlnagy
Copy link
Member Author

tlnagy commented Nov 26, 2018

As @Mattriks says, this PR needs to throw a warning to alert users to the change in behavior.

If you merge this PR, I can add svgalphatest in another PR?

This is fine, IMO

@bjarthur bjarthur merged commit 9e1682b into GiovineItalia:master Nov 28, 2018
@bjarthur
Copy link
Member

@Mattriks add the test and then we can tag

@Mattriks
Copy link
Member

The above merge had a side-effect: the fill(nothing) statement in a parent context now clobbers the fill(color) statement in a nested context (for svg). See the 2 examples in the Transformations gallery, which both use nested contexts. I should be able to sort that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants