-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert to using hex for fill colors instead of RGBA #324
Conversation
This reverts commit c414a3f. Working on
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
- Coverage 79.44% 31.3% -48.14%
==========================================
Files 14 18 +4
Lines 1192 3031 +1839
==========================================
+ Hits 947 949 +2
- Misses 245 2082 +1837
Continue to review full report at Codecov.
|
bump |
is this ready to merge? or is it stale? |
The function |
As @Mattriks says, this PR needs to throw a warning to alert users to the change in behavior.
This is fine, IMO |
@Mattriks add the test and then we can tag |
The above merge had a side-effect: the |
2nd part of #322