Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Default naming of OpenHome renderer #356

Closed
GioF71 opened this issue Dec 19, 2023 · 0 comments · Fixed by #357
Closed

[Enhancement] Default naming of OpenHome renderer #356

GioF71 opened this issue Dec 19, 2023 · 0 comments · Fixed by #357
Assignees
@GioF71
Labels
enhancement New feature or request

Comments

@GioF71
Copy link
Owner

GioF71 commented Dec 19, 2023

If FRIENDLY_NAME is set (but not the individual renderer values) and both UPNPAV and OPENHOME are set, the default name for the OpenHome renderer should be:

"${FRIENDLY_NAME} (oh)"

so it will be consistent with the UPNPAV version which is already

"${FRIENDLY_NAME} (av)"

So naming should be more consistent (at least IMO).
You are still free to set distinct names for renderers.
@GioF71 GioF71 changed the title [Enhancement] Naming of oh renderer [Enhancement] Default naming of OpenHome renderer Dec 19, 2023
@GioF71 GioF71 self-assigned this Dec 19, 2023
@GioF71 GioF71 added the enhancement New feature or request label Dec 19, 2023
GioF71 added a commit that referenced this issue Dec 19, 2023
@GioF71
[Enhancement] Default naming of OpenHome renderer #356
05b68e7
@GioF71 GioF71 linked a pull request Dec 19, 2023 that will close this issue
[Enhancement] Default naming of OpenHome renderer #356 #357
Merged
GioF71 added a commit that referenced this issue Dec 19, 2023
@GioF71
[Enhancement] Default naming of OpenHome renderer #356 (#357)
4c4e3cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GioF71 GioF71

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] Default naming of OpenHome renderer #356 GioF71/upmpdcli-docker
1 participant
@GioF71