-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added button to show actual value in editor #4102
Added button to show actual value in editor #4102
Conversation
WalkthroughThis pull request adds a new "Show Actual Value" feature to the action editing page. A new DataTemplate and button are integrated into the XAML, and its corresponding click event handler is implemented in the code-behind to extract a selected grid value, generate a temporary text file, and display it in a separate window. Additionally, a helper method for file deletion is introduced in the general utilities library. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ActionEditPage
participant xOutputValuesGrid
participant FileSystem
participant ViewerWindow
User->>ActionEditPage: Click "Show Actual Value" button
ActionEditPage->>xOutputValuesGrid: Retrieve selected ActReturnValue
xOutputValuesGrid-->>ActionEditPage: Return ActReturnValue (with Actual value)
ActionEditPage->>FileSystem: Create temporary text file with Actual value
FileSystem-->>ActionEditPage: Return temp file path
ActionEditPage->>ViewerWindow: Open viewer window with temp file and title "Actual Value"
ViewerWindow-->>User: Display actual value content
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
Ginger/Ginger/Actions/ActionEditPage.xaml
(1 hunks)Ginger/Ginger/Actions/ActionEditPage.xaml.cs
(2 hunks)Ginger/Ginger/AutomatePageLib/AddActionMenu/SharedRepositoryLib/RepositoryItemPage.xaml.cs
(1 hunks)
🔇 Additional comments (3)
Ginger/Ginger/AutomatePageLib/AddActionMenu/SharedRepositoryLib/RepositoryItemPage.xaml.cs (1)
41-46
: Well-implemented constructor overload!The new constructor cleanly extends functionality by adding edit mode control while maintaining code reuse.
Ginger/Ginger/Actions/ActionEditPage.xaml (1)
34-36
: Well-structured DataTemplate addition!The template maintains consistency with existing button styles and provides clear user guidance through the tooltip.
Ginger/Ginger/Actions/ActionEditPage.xaml.cs (1)
972-972
: Well-integrated grid column addition!The new column for showing actual values follows the established grid pattern and maintains UI consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
Ginger/Ginger/Actions/ActionEditPage.xaml.cs
(2 hunks)Ginger/GingerCoreNET/GeneralLib/General.cs
(1 hunks)
🔇 Additional comments (1)
Ginger/Ginger/Actions/ActionEditPage.xaml.cs (1)
972-972
: LGTM!The grid column for the "Show Actual Value" button is properly integrated with the existing grid structure.
Thank you for your contribution.
Before submitting this PR, please make sure:
Summary by CodeRabbit