Get datepicker fixes from ui.boostrap 0.13.1

[artaommahe]

Currently datetimepicker does not work with ng-if(as datepicker at 0.13.0), but there was some fixes at this 0.13.1 commit
angular-ui/bootstrap@b72efed

(also there was some more commits for datepicker.js file since 0.13.0 https://github.com/angular-ui/bootstrap/commits/master/src/datepicker/datepicker.js)

It's important fix due to 150+ watchers by every datetime picker on page. Hope you will have time to grab it here :)

[Gillardo]

I will look at implementing any bugs that are in datetime picker that have
been fixed in date picker popular from angular-ui, but a plunk would be
helpful so I can see the bugs.

Any bugs that exist in date picker and time picker can be fixed if u
upgrade your angular ui js file as my directive just uses that code.
On 2 Aug 2015 2:57 pm, "artaommahe" [email protected] wrote:

Currently datetimepicker does not work with ng-if(as datepicker at
0.13.0), but there was some fixes at this 0.13.1 commit
angular-ui/bootstrap@b72efed
angular-ui/bootstrap@b72efed

(also there was some more commits for datepicker.js file since 0.13.0
https://github.com/angular-ui/bootstrap/commits/master/src/datepicker/datepicker.js
)

It's important fix due to 150+ watchers by every datetime picker on page.
Hope you will have time to grab it here :)

—
Reply to this email directly or view it on GitHub
#35.

[Gillardo]

What fix is it for 150+ watchers? ?
On 2 Aug 2015 2:57 pm, "artaommahe" [email protected] wrote:

Currently datetimepicker does not work with ng-if(as datepicker at
0.13.0), but there was some fixes at this 0.13.1 commit
angular-ui/bootstrap@b72efed
angular-ui/bootstrap@b72efed

(also there was some more commits for datepicker.js file since 0.13.0
https://github.com/angular-ui/bootstrap/commits/master/src/datepicker/datepicker.js
)

It's important fix due to 150+ watchers by every datetime picker on page.
Hope you will have time to grab it here :)

—
Reply to this email directly or view it on GitHub
#35.

[Gillardo]

I have had a look at ng-if and i had this before, the problem is that the
timepicker does not then work. If you change the code needed to the demo
and then try the timepicker demo, change the time by a few minutes, and
then press the Now button. You will notice that the input and time picker
are out of sync.

I will have a look if i can apply the ng-if on just the datePicker, instead
of the picker as a whole.

On Sun, Aug 2, 2015 at 6:33 PM, Darren Gillard [email protected]
wrote:

What fix is it for 150+ watchers? ?
On 2 Aug 2015 2:57 pm, "artaommahe" [email protected] wrote:

Currently datetimepicker does not work with ng-if(as datepicker at
0.13.0), but there was some fixes at this 0.13.1 commit
angular-ui/bootstrap@b72efed
angular-ui/bootstrap@b72efed

(also there was some more commits for datepicker.js file since 0.13.0
https://github.com/angular-ui/bootstrap/commits/master/src/datepicker/datepicker.js
)

It's important fix due to 150+ watchers by every datetime picker on page.
Hope you will have time to grab it here :)

—
Reply to this email directly or view it on GitHub
#35.

[artaommahe]

Thx :)
yep, i knew about timepicker bug, tried to fix ng-if by myself, failed and then came here. Also they fixed one more important thing last day(router cross-state transition $digest error with opened calendar popup)

angular-ui/bootstrap#4079 (issue with plunk angular-ui/bootstrap#4076)

[Gillardo]

I have now updated the code with some changes from bootstrap-ui. I will upload these shortly.

[Gillardo]

I have now put version 1.1.6 up and released. If you could give it a go that would be great. I will close this issue now, but please reopen if something is amiss

[Gillardo]

I have just release 1.2.0 which now applies many of the angular-ui bug fixes, including ngIf. The previous version 1.1.6 had some bugs in it, so i had to revert

[artaommahe]

Yep, 1.2.0 fixed everything, thx ;)

[Gillardo]

Wicked! Glad it all works. Will use it in my project now, hopefully
improve performance a bit :)

On Wed, Aug 26, 2015 at 3:05 PM, artaommahe [email protected]
wrote:

Yep, 1.2.0 fixed everything, thx ;)

—
Reply to this email directly or view it on GitHub
#35 (comment)
.

[artaommahe]

One small bug/typo
ReferenceError: keydown is not defined
on datepicker destroy. It's about this line
element.unbind('keydown', keydown);

[Gillardo]

uploading fix now for you

On Wed, Aug 26, 2015 at 3:22 PM, artaommahe [email protected]
wrote:

One small bug/typo

ReferenceError: keydown is not defined
on datepicker destroy

—
Reply to this email directly or view it on GitHub
#35 (comment)
.