Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DOCX list styling to use List Paragraph style #482

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

smcgu
Copy link
Contributor

@smcgu smcgu commented Jul 19, 2024

Identify the Bug

List items are incorrectly styled as Normal when they should be styled with List Paragraph.

Description of the Change

  • Apply "List Paragraph" style to list paragraphs
  • Adjusted tests to check for styling

Current/Before generated XML:

<w:p>
    <w:pPr>
        <w:numPr>
            <w:ilvl w:val="0"/>
            <w:numId w:val="32"/>
        </w:numPr>
    </w:pPr>
    <w:r>
        <w:t>List item</w:t>
    </w:r>
</w:p>

Corrected/Fixed generated XML:

<w:p>
    <w:pPr>
        <w:pStyle w:val="ListParagraph"/>
        <w:numPr>
            <w:ilvl w:val="0"/>
            <w:numId w:val="32"/>
        </w:numPr>
    </w:pPr>
    <w:r>
        <w:t>List item</w:t>
    </w:r>
</w:p>

Alternate Designs

None.

Possible Drawbacks

None

Verification Process

  1. Updated tests to check for correct style in generated XML.
  2. Manual verification of generated reports.

Release Notes

  • Fixed Docx list paragraph style

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (eb9bd85) to head (a5d9b9e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         314      314           
  Lines       18146    18146           
=======================================
  Hits        16689    16689           
  Misses       1457     1457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrismaddalena
Copy link
Collaborator

Alex tested this and it looks like everything is in order so this is good to merge. Thanks for the submission @smcgu!

@chrismaddalena chrismaddalena merged commit 0a124cf into GhostManager:master Jul 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants