Hotfix for Checkout Mutations #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_reports` tag for the "My Active Reports" sidebar dropdown made a list of reports based on a user's project assignments. We repeated this for the project assignments under the "My Active Projects" dropdown. For projects, we referenced `if request.user.projectassignment_set.all`. If a project was marked complete, we weren't showing it in the sidebar, but if a user's projects were all marked as complete the dropdown would appear to be broken (no "no assignments" message). Rather than repeat what we did for `get_reports` and continue making the same query twice, I condensed it all into one tag that returns a unique list of projects and reports.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 91.96% 91.97%
=======================================
Files 314 314
Lines 18132 18146 +14
=======================================
+ Hits 16675 16689 +14
Misses 1457 1457 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This includes a pair of small bug fixes. It also includes CHANGELOG and version updates for v4.2.2.
CHANGELOG
Fixed
checkoutServerandcheckoutDomainmutations in the GraphQL API and providing a null value for thenotefield