Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper escaping of finding names in report detail page #375

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ColonelThirtyTwo
Copy link
Collaborator

Identify the Bug

Issue #374

Description of the Change

In the report detail template, fix escaping of the finding title to use the proper Javascript escaping.

Alternate Designs

None

Possible Drawbacks

None

Verification Process

Created a finding named '];alert(0);let testx = ['a and a test report. Viewed the test report's detail page with and without the patch. Tested adding the finding to the report.

Release Notes

  • Fix improper escaping of finding names in report detail page

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3363f9e) 92.28% compared to head (d75ac73) 92.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   92.28%   92.29%           
=======================================
  Files         258      258           
  Lines       16038    16038           
=======================================
+ Hits        14801    14802    +1     
+ Misses       1237     1236    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrismaddalena chrismaddalena merged commit 44342c4 into GhostManager:master Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants