Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#357
Description of the Change
This change adds the nmap binary to both local and production django containers.
Production django container is not running as root and cannot run an nmap scan with
-sS
:libcap
has been added to the production docker container in order to set the nmap binary capabilities so as to not require rootAlternate Designs
Running the container as root in production is a security risk. So this was not explored.
Nmap can be used without priviledges using the environment variable or using a
--privileged
option. Using the--privileged
option would require this to be added to the rolodex tasks function instead.Possible Drawbacks
Nmap is installed on the container potentially allowing anyone who has access to the container cli to run a SYN scan against the localhost or other servers not owned by the user
Verification Process
queue
container as expected - correct binarys installed, cap's set correctly, env variable setRelease Notes