Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing space between cross-reference and following text. #508

Closed
smcgu opened this issue Aug 27, 2024 · 2 comments · Fixed by #510
Closed

Missing space between cross-reference and following text. #508

smcgu opened this issue Aug 27, 2024 · 2 comments · Fixed by #510
Assignees
Labels
bug Something isn't working

Comments

@smcgu
Copy link
Contributor

smcgu commented Aug 27, 2024

Describe the bug

The space between a cross-reference and the following text is missing.

Input:

<p>{{.ref some-evidence}} shows the compromise.</p>

Output:

Figure 1shows the compromise.

To Reproduce

Steps to reproduce the behavior:

  1. Add cross-reference to text sentence/paragraph in finding
  2. Generate DOCX report

Expected Behavior

The space should be maintained and present.

Input:

<p>{{.ref some-evidence}} shows the compromise.</p>

Output:

Figure 1 shows the compromise.

Server Specs:

  • OS: Ubuntu
  • Docker: v27.1.2, build d01f264
  • Docker Compose: v2.29.1
  • Ghostwriter: v4.2.5 (but, this has been present for multiple versions)
@smcgu smcgu added the bug Something isn't working label Aug 27, 2024
@chrismaddalena
Copy link
Collaborator

Hey @smcgu, I'm unable to reproduce this in most scenarios. This HTML produces this in Word.

<p>{{.Benny}}</p>
<p>This is a cross-ref for Benny {{.ref benny}} right here.</p>
image

The situation seems to be the space is only lost if you start a sentence with the cross-reference. We'll take a look and see why that happens.

@smcgu
Copy link
Contributor Author

smcgu commented Aug 27, 2024

I should have included that in my earlier issue post but that aligns with my experience, too. It seems to only impact cross references at the start of a sentence.

I'll definitely update this issue if I see it elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants