Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add byte conversion to allow int NBT values for Fireworks #681

Merged
merged 3 commits into from
May 28, 2020

Conversation

rtm516
Copy link
Member

@rtm516 rtm516 commented May 28, 2020

Fixes #679

@rtm516 rtm516 added the PR: Bugfix When a PR contains a bugfix label May 28, 2020
@rtm516 rtm516 changed the title Add byte conversion to allow int NBT values Add byte conversion to allow int NBT values for Fireworks May 28, 2020
@Arktisfox
Copy link
Contributor

Would Integer.valueOf( nbt tag ).byteValue(); work better here, instead of converting to string and back?

@rtm516
Copy link
Member Author

rtm516 commented May 28, 2020

Would Integer.valueOf( nbt tag ).byteValue(); work better here, instead of converting to string and back?

No because it is sometimes a byte and sometimes an int, whereas that only takes int or string, so it would need a toString again

@Arktisfox
Copy link
Contributor

Tested on Paper with the commands listed in the issue, appears to be fixed (both entity and item forms)

@Camotoy Camotoy merged commit 1a92f69 into GeyserMC:master May 28, 2020
@rtm516 rtm516 deleted the firework-byte-fix branch May 28, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bugfix When a PR contains a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Fireworks [java.lang.Integer cannot be cast to class java.lang.Byte (FireworkEntity)]
4 participants