Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register permissions in Spigot plugin.yml #2246

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Register permissions in Spigot plugin.yml #2246

merged 2 commits into from
Jun 1, 2021

Conversation

Konicai
Copy link
Member

@Konicai Konicai commented Jun 1, 2021

I'm not sure if having to specify a description will override anything. It doesn't affect Geyser's geyser help command (tested by setting a locale other than en_us)

Considering the permissions weren't defined in the first place, its not like this will break anything that uses spigot's command#getDescription() method.

Apart from that API method I don't know where permission descriptions are used.

Resolves the LuckPerms tree part of #2239

@Camotoy
Copy link
Member

Camotoy commented Jun 1, 2021

Have you confirmed that it fixes the issue for sure? I.E. the replication steps no longer apply.

@Konicai
Copy link
Member Author

Konicai commented Jun 1, 2021

with this PR: https://luckperms.net/treeview/e0qzpRBdeX (with a typo that I've fixed)
without: https://luckperms.net/treeview/z1123vBCMT

I don't think I ran geyser commands before getting the tree.

I realized I haven't tried running the command first as they suggested though.

@Konicai
Copy link
Member Author

Konicai commented Jun 1, 2021

Well I can confirm that running a geyser command before running the tree command does in fact make the command's permission appear in the LP tree.

I'm not exactly sure what you mean by the replication steps no longer applying though.

With this, the commands no longer need to be ran beforehand to get them to appear

@Camotoy
Copy link
Member

Camotoy commented Jun 1, 2021

Yes, that would count as resolving.

@Konicai
Copy link
Member Author

Konicai commented Jun 1, 2021

I will note I haven't checked if commands still show up in tab-complete if the player doesnt have the permission.

@Konicai
Copy link
Member Author

Konicai commented Jun 1, 2021

Yeah this in fact does not fix the auto-complete showing despite not having permission issue.

@Camotoy
Copy link
Member

Camotoy commented Jun 1, 2021

That's another issue that can be resolved later.

@Camotoy Camotoy merged commit 4c542ba into GeyserMC:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants