Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings not displaying due to bedrock bug by delaying 1s #2010

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Fix settings not displaying due to bedrock bug by delaying 1s #2010

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
970d84e
Fix settings not displaying due to bedrock bug by delaying 1s
rtm516 Mar 7, 2021
5ff3a87
Update BedrockServerSettingsRequestTranslator.java
rtm516 Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...eysermc/connector/network/translators/bedrock/BedrockServerSettingsRequestTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,20 @@
import org.geysermc.connector.network.translators.Translator;
import org.geysermc.connector.utils.SettingsUtils;

import java.util.concurrent.TimeUnit;

@Translator(packet = ServerSettingsRequestPacket.class)
public class BedrockServerSettingsRequestTranslator extends PacketTranslator<ServerSettingsRequestPacket> {

@Override
public void translate(ServerSettingsRequestPacket packet, GeyserSession session) {
SettingsUtils.buildForm(session);

ServerSettingsResponsePacket serverSettingsResponsePacket = new ServerSettingsResponsePacket();
serverSettingsResponsePacket.setFormData(session.getSettingsForm().getJSONData());
serverSettingsResponsePacket.setFormId(SettingsUtils.SETTINGS_FORM_ID);
session.sendUpstreamPacket(serverSettingsResponsePacket);
session.getConnector().getGeneralThreadPool().schedule(() -> {
rtm516 marked this conversation as resolved.
Show resolved Hide resolved
ServerSettingsResponsePacket serverSettingsResponsePacket = new ServerSettingsResponsePacket();
serverSettingsResponsePacket.setFormData(session.getSettingsForm().getJSONData());
serverSettingsResponsePacket.setFormId(SettingsUtils.SETTINGS_FORM_ID);
session.sendUpstreamPacket(serverSettingsResponsePacket);
}, 1, TimeUnit.SECONDS);
}
}