Block breaking refactors #1336
Merged
Block breaking refactors #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally we did not translate if this packet failed. With this commit, a lot (if not all) of the ghost block issues with mobile devices should be solved if the player is running a new enough version that supports this packet. If the packet returns not successful, we reset the block back to its original type. This commit also includes cleanup in BlockChangeTranslator as well as proper Netherite tool support for calculating block breaking.
Originally we did not translate if this packet failed. With this commit, a lot (if not all) of the ghost block issues with mobile devices should be solved if the player is running a new enough version that supports this packet. If the packet returns not successful, we reset the block back to its original type. This commit also includes cleanup in BlockChangeTranslator as well as proper Netherite tool support for calculating block breaking.
Don't rely on ServerPlayerActionAckPacket; just do it ourselves.
Camotoy
changed the title
This was
linked to
issues
Oct 12, 2020
|
!start-test-server |
|
Preparing and starting test server as requested by @DoctorMacc at 2020-12-09 19:11:52 UTC Downloading Geyser Standalone... Finished download, setting up docker container... Built docker container. Connect via 51.210.124.95:32818 ( |
rtm516
requested changes
Jan 7, 2021
...rg/geysermc/connector/network/translators/bedrock/BedrockInventoryTransactionTranslator.java
Show resolved
Hide resolved
...rg/geysermc/connector/network/translators/bedrock/BedrockInventoryTransactionTranslator.java
Show resolved
Hide resolved
...rg/geysermc/connector/network/translators/bedrock/BedrockInventoryTransactionTranslator.java
Outdated
Show resolved
Hide resolved
…tors/bedrock/BedrockInventoryTransactionTranslator.java Co-authored-by: rtm516 <[email protected]>
rtm516
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client-side block animations and reach are now added.
This commit also includes cleanup in BlockChangeTranslator as well as proper Netherite tool support for calculating block breaking.