Armor stand fixes #1270
Merged
Armor stand fixes #1270
+274
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Camotoy
commented
Sep 10, 2020
Camotoy
commented
- Armor stands now show armor if invisible. This allows both names and armor to show on an armor stand, and should allow for custom models that use armor stands to show, to an extent. I've been unable to find a custom model plugin at this time so verification on this would be great.
- Armor stand orientation when visible is now correct.
- Armor stands now show armor if invisible. This allows both names and armor to show on an armor stand, and should allow for custom models that use armor stands to show, to an extent. I've been unable to find a custom model plugin at this time so verification on this would be great. - Armor stand orientation when visible is now correct.
Redned235
approved these changes
Sep 15, 2020
|
I noticed armor stands with nametags work fine with Bedrock on PC and Mobile, but on Xbox (possibly PS4 and Switch too) they aren't visible. Will this fix those inconsistencies and allow armor stand names to show on Xbox? |
|
Note: 047bf5f may make something here irrelevant. |
|
Is there anything blocking this PR from being merged? |
|
I'm simply concerned about performance implications. |
|
Hopefully will be merged soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.