Fix CI not running tests below iOS 14 #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 89.17% 89.36% +0.18%
==========================================
Files 201 201
Lines 8271 8271
==========================================
+ Hits 7376 7391 +15
+ Misses 895 880 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nuno-vieira
force-pushed
the
fix-ci-not-running-tests-on-ios-below-14
branch
26 times, most recently
from
3729695 to
b82af52
Compare
nuno-vieira
force-pushed
the
fix-ci-not-running-tests-on-ios-below-14
branch
6 times, most recently
from
cb03b92 to
7b897d7
Compare
VojtaStavik
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR
The tests were not running below < iOS 14. It would fall back to the default device 🤦♂️
Issues found:
options[:device]parameter on the lanes. Even if the prepare-simulator-action was working, the stress tests were always running on the default device.The script needs to have a condition because of how the Xcode path is different on 10.3 vs >10.3
More details here: actions/runner-images#551 (comment)
Now I finally got why the iOS 12 coverage was the same as the iOS 14 😄
It probably would be a good idea to open source this action actually 🤔 It took a lot of time to make it work properly for every case.