Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Channel List search bar disappearing #3515

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Nov 28, 2024

🔗 Issue Links

Fixes https://linear.app/stream/issue/IOS-582

🎯 Goal

Fix Channel List search bar disappearing in rare cases. If the number of items was about 10, the channel list would be scrollable initially with the Search Bar shown. After scrolling to the bottom, the search bar would disappear, losing the scrollability.

🛠 Implementation

The alwaysBounceVertical should be set to true so that the scrollability is never lost and the Search Bar reappears again.

🧪 Manual Testing Notes

  • Open the channel list with "General Grievous"
  • It should have exactly 10 channels only in the Channel List
  • Scroll to the bottom and up again
  • Search bar should always be visible

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added 🐞 Bug An issue or PR related to a bug 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK labels Nov 28, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner November 28, 2024 16:37
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Nov 28, 2024

SDK Size

title develop branch diff status
StreamChat 7.06 MB 7.06 MB 0 KB 🟢
StreamChatUI 4.96 MB 4.96 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 5.01 ms 49.9% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 1.97 ms per s 50.75% 🔼 🟢
Frame rate 75 fps 78.12 fps 4.16% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢

Copy link

sonarcloud bot commented Nov 28, 2024

Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this change fixes the issue. Marking as QAd

@laevandus laevandus added the 🟢 QAed A PR that was QAed label Nov 29, 2024
@nuno-vieira nuno-vieira merged commit 4b87a3e into develop Nov 29, 2024
13 checks passed
@nuno-vieira nuno-vieira deleted the fix/channel-list-search-disappears branch November 29, 2024 09:56
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug 🟢 QAed A PR that was QAed 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants