Convert to models after NSFetchedResultsController finishes reporting changes #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
laevandus
added
🐞 Bug
SDK Performance
|
laevandus
force-pushed
the
fix/core-data-update-cycle
branch
from
07eae5b
to
629460a
Compare
laevandus
changed the title
… changes for avoiding update cycle triggered by fetch requests in item creator
laevandus
force-pushed
the
fix/core-data-update-cycle
branch
from
629460a
to
a1bc59e
Compare
SDK Size
|
|
nuno-vieira
reviewed
Nov 26, 2024
Comment on lines
+222
to
+223
| // Model conversion is safe when all the changes have been processed (Core Data's _processRecentChanges can be called if conversion triggers additional fetch requests). | ||
| let itemChanges = currentChanges.compactMap { dtoChange in |
There was a problem hiding this comment.
This makes sense. Does this potentially fix the current workaround we have with the depth stuff?
There was a problem hiding this comment.
Unfortunately no because the circular cycle can still occur with MessageDTO's replies contains a quoted message.
|
I've QA it myself, it seems to work fine 👍 At least I was not able to reproduce the crash anymore. |
nuno-vieira
added
🟢 QAed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves IOS-569
🎯 Goal
Fix a crash caused by infinite loop in Core Data when converting models
📝 Summary
NSFetchedRequestControllerhas finished reporting changes🛠 Implementation
We had an internal crash report which showed that Core Data change came in, triggered
NSFetchedRequestControllerdelegate, then we converted the DTO to a model type, but since the model type did another fetch request, this triggered the whole cycle again. Therefore, let's avoid it by delaying the model conversion to the point of time whereNSFetchedRequestControllerhas finished reporting changes.🧪 Manual Testing Notes
Retrying the flow in IOS-569 which triggered it.
☑️ Contributor Checklist