NonEmpty ToSchema instance #141
Conversation
|
Apparently your branch is out-of-date. Apart from that, I'm happy with the patch! @phadej you have any comments? |
|
The doctests are failing locally for some reason, but aren't displaying any output 🤷♂️ I had to vendor an |
|
Use |
swagger2.cabal
Outdated
| @@ -96,6 +98,9 @@ test-suite spec | |||
| , unordered-containers | |||
| , vector | |||
| , lens | |||
| if !impl(ghc >= 8.0) | |||
| build-depends: semigroups >= 0.18.3 && <0.19 | |||
There was a problem hiding this comment.
no need to specify bounds in test-suite (as they are inherited from library). This helps if/when semigroups-0.19 is released.
| @@ -260,3 +262,13 @@ instance Arbitrary ZonedTime where | |||
|
|
|||
| instance Arbitrary UTCTime where | |||
| arbitrary = UTCTime <$> arbitrary <*> fmap fromInteger (choose (0, 86400)) | |||
|
|
|||
| #if MIN_VERSION_QuickCheck(2,10,0) | |||
There was a problem hiding this comment.
|
Requested changes done :) Thanks! |
|
@phadej are you fine with changes? I can rebase and merge. |
| instance Arbitrary T.Text where | ||
| arbitrary = T.pack <$> arbitrary | ||
|
|
||
| instance Arbitrary TL.Text where |
|
@fizruk let's btw wait until we get dependencies to compile with GHC-8.4.1 and make the release then. Do you have some pending changes, or will master be ok to release? |
|
@fizruk good plan |
NonEmpty ToSchema instance * parsonsmatt-master: Remove unused instance code use quickcheck-instances Fix tests Add semigroups build dep (squash-me) support GHC 7.x Add ToSchema NonEmpty instance for GHC 8.
|
Rebased and merged manually in 22e975e. |
|
Thanks! 😄 |
This would be nice to have :) @lucasdicioccio put this in the #93 issue. It seems good to me so I'm opening a PR for it and will be willing to make further changes.