-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GHC-8.2 #108
Support GHC-8.2 #108
Conversation
Ping @fizruk, are you ok with going with |
@phadej anything to make it work :) |
@fizruk, could you recheck. I can then make the release. |
ping @fizruk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, feel free to merge! :)
swagger2.cabal
Outdated
test-suite doctest | ||
build-depends: base, doctest, Glob | ||
test-suite doctests | ||
build-depends: base, doctest, Glob, QuickCheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QuickCheck?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have one prop>
, it requires QuickCheck
then.
This is a little hack, actually we don't need QuickCheck
to build doctests.hs
; but these dependencies are solved by Cabal, so we can pass them as --package-id=...
to doctests
executable, so doctest
can use / import QuickCheck
modules (done by cabal-doctests
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add this comment to the file then? Or a link to this conversation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add an entry to cabal-doctest
FAQ/Notes and add a link here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a PR. ulidtko/cabal-doctest#16 and added a link to where it will land.
No description provided.