Support PHP 8.1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a single test and it was failing, because it was a bad test. I expanded the tests so they give us 100% coverage, and some generic easily-testable cases as well. |
jastraat
approved these changes
Mar 7, 2023
| <exclude name="Drupal.Commenting.FunctionComment.Missing"/> | ||
| <exclude name="Drupal.Commenting.DocComment.MissingShort"/> | ||
| </rule> | ||
| <rule ref="DrupalPractice"/> |
There was a problem hiding this comment.
@paul-m The other DKAN libraries were using PSR1 and PSR2. Just curious as to why this one is using the DrupalPractice instead?
There was a problem hiding this comment.
Per Paul, "pdlt looks like Drupal rather than PSR1/2, so I enforced that. " So we're good :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.