Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Fix settings.docker.demo.php for Docker Compose v2, memcached #475

Merged
merged 2 commits into from
Jan 9, 2018

Conversation

kducharm
Copy link
Member

@kducharm kducharm commented Dec 14, 2017

Fixes settings.docker.demo.php for Docker Compose v2, memcached server settings

QA

  • Verify upgrading a site to this branch works
  • Memcached should be functioning when used with Docker (host: memcached:11211)

@janette
Copy link
Member

janette commented Dec 27, 2017

@kducharm

                Name                              Command               State                                   Ports                                  
------------------------------------------------------------------------------------------------------------------------------------------------------
ngworldbankcaribbjamdata_browser_1     /opt/bin/entry_point.sh          Up      4444/tcp, 0.0.0.0:32939->5900/tcp                                      
ngworldbankcaribbjamdata_cli_1         /opt/startup.sh /bin/sh -c ...   Up      0.0.0.0:32940->8888/tcp                                                
ngworldbankcaribbjamdata_db_1          /entrypoint.sh mysqld            Up      0.0.0.0:32941->3306/tcp                                                
ngworldbankcaribbjamdata_memcached_1   docker-entrypoint.sh memcached   Up      11211/tcp                                                              
ngworldbankcaribbjamdata_solr_1        /bin/sh -c /opt/startup.sh;      Up      0.0.0.0:32935->8983/tcp                                                
ngworldbankcaribbjamdata_web_1         /bin/sh -c /opt/startup.sh ...   Up      0.0.0.0:32937->443/tcp, 0.0.0.0:32938->80/tcp, 0.0.0.0:32936->8888/tcp 

but when I run ahoy site up I get

ENVIRONMENT set to , but not mapped in settings.php
Drush command terminated abnormally due to an unrecoverable error.

@kducharm
Copy link
Member Author

@janette can you check that GetDKAN/dkan@b926e2b is in your branch? That is merged, but I think it's only in 7.x-1.x and not 1.14 atm. It may be in 1.15 but I haven't checked.

@janette
Copy link
Member

janette commented Dec 27, 2017

@kducharm that is not in the branch I am updating, also it does not have .ahoy/docker-compose.common.yml so I can't apply the patch

@kducharm
Copy link
Member Author

@janette Can you try this updated branch, I left in fallbacks for docker-machine so it won't depend on that other DKAN commit

@kducharm kducharm mentioned this pull request Dec 28, 2017
2 tasks
@kducharm kducharm force-pushed the docker-db-creds-kd branch from b66d0bf to e8a3975 Compare January 3, 2018 00:22
@janette
Copy link
Member

janette commented Jan 3, 2018

@kducharm if I add the config to settings.custom.php it works

$conf['memcache_servers'] = array($memcache_server => 'default');
$conf['cache_backends'][] = 'sites/all/modules/contrib/memcache/memcache.inc';
$conf['cache_default_class'] = 'MemCacheDrupal';

was that implied in the "Memcached should be functioning"

@kducharm
Copy link
Member Author

kducharm commented Jan 8, 2018

@janette You shouldn't have to add anything to make memcache work if this PR is working (locally)... those lines are in settings.docker.demo.php. I'm not sure how you were testing, but make sure that settings.docker.demo.php got copied to settings.docker.php. If you're using docker machine, ahoy docker exec env should output MEMCACHED_PORT_11211_TCP_ADDR, and if so, then settings.docker.php should work.

@kducharm kducharm changed the base branch from master to develop January 8, 2018 19:33
@kducharm kducharm changed the base branch from develop to master January 8, 2018 19:36
@janette
Copy link
Member

janette commented Jan 8, 2018

@kducharm the output of ahoy docker exec env and settings.docker.php look good but if I enable memcache I get this error

There are problems with your Memcache configuration. Please review README.txt and visit the Drupal admin status report page for more information.
Failed to load required file sites/all/modules/contrib/memcache/dmemcache.inc.

is that outside the scope of this ticket?

@janette janette merged commit 20d19d6 into master Jan 9, 2018
@janette janette deleted the docker-db-creds-kd branch January 9, 2018 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants