Make response stream caching max-age a configuration #4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janette
changed the title
janette
changed the title
zedmonds96
force-pushed
the
WCMS-21638
branch
from
8958a18 to
bbf189c
Compare
|
@zedmonds96 set this back to draft as tests are failing. Are you still working on this? |
zedmonds96
force-pushed
the
WCMS-21638
branch
from
30f550d to
0c083be
Compare
paul-m
requested changes
Dec 30, 2024
modules/datastore/tests/src/Unit/Controller/QueryDownloadControllerTest.php
Show resolved
Hide resolved
paul-m
requested changes
Dec 30, 2024
…d updated docblock.
paul-m
approved these changes
Jan 3, 2025
paul-m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes see 21638
Describe your changes
datastore_response_stream_max_agetodatastore.settings.ymlwith a default of 3600 seconds.DatastoreSettingsFormto include a configurable field for response stream max-age.QueryDownloadControllerto use the configuredresponse_stream_max_ageinstead of a hardcoded value.QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation