Handle missing resource when dropping a datastore #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janette
approved these changes
Nov 20, 2024
janette
deleted the
4340-handle-missing-resource-when-dropping-a-datastore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4340
Describe your changes
Checks whether the resource could be loaded before sending it as an event.
This probably speaks to a larger issue where our resource mapper and the resources they map get out of sync.
There might also be a better way to generate a DataResource object to add to the event than to use the localizer.
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation