Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events for datastore pre-drop, drop, and import #4312

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Add events for datastore pre-drop, drop, and import #4312

merged 14 commits into from
Oct 22, 2024

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Oct 11, 2024 •
edited
Loading

Re: 22964 and 22872

Describe your changes

Adds these events:

  • DatastoreService::EVENT_DATASTORE_PRE_DROP
  • DatastoreService::EVENT_DATASTORE_DROPPED
  • ImportService::EVENT_DATASTORE_IMPORTED

This way other services can respond to these events.

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform. Be as specific as possible, provide examples if appropriate.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@paul-m paul-m marked this pull request as ready for review October 13, 2024 18:21
@paul-m paul-m requested a review from dafeder October 17, 2024 16:05
dafeder
dafeder approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Hope to factor out the EventDispatcherTrait in other places soon too

@dafeder dafeder merged commit 8991a0e into 2.x Oct 22, 2024
11 checks passed
@paul-m paul-m mentioned this pull request Oct 23, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-m @dafeder