-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to drop datastore if there is an error on post_import #4311
Conversation
2ba45ca
to
b3d2f80
Compare
Test drop logic on post-import error.
@janette I had to change the way 'datastore.settings' is retrieved so that it comes from the config factory so it can be stored as a config object for the test. Let me know if this is wrong and/or messes anything up. |
bc363eb
to
65ef768
Compare
65ef768
to
ac007ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello wowee good stuff (very helpful to look into the test files too). Just one minor possibly redundant question as well as one piece of code cleanup. Thanks!
modules/datastore/tests/src/Unit/Plugin/QueueWorker/PostImportResourceProcessorTest.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
RE: 22023
Describe your changes
Adds a config option to drop the datastore table if the post_import queue reports an error
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation