DKAN-4291 add mysql empty row removal option #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swirtSJW
force-pushed
the
DKAN-4291-add-mysql-empty-rows-option
branch
2 times, most recently
from
5e7ec8f to
01f1300
Compare
swirtSJW
commented
Sep 18, 2024
modules/datastore/modules/datastore_mysql_import/src/Service/MysqlImport.php
Outdated
Show resolved
Hide resolved
swirtSJW
commented
Sep 18, 2024
modules/datastore/modules/datastore_mysql_import/src/Service/MysqlImport.php
Outdated
Show resolved
Hide resolved
|
Thanks for working on this @swirtSJW please include tests for the new code. |
@swirtSJW check out the tests |
swirtSJW
force-pushed
the
DKAN-4291-add-mysql-empty-rows-option
branch
from
99f0f61 to
6e4757f
Compare
swirtSJW
commented
Oct 16, 2024
modules/datastore/modules/datastore_mysql_import/tests/data/multiple_empty_rows.csv
Outdated
Show resolved
Hide resolved
swirtSJW
force-pushed
the
DKAN-4291-add-mysql-empty-rows-option
branch
from
8e9b6a1 to
a501f86
Compare
swirtSJW
force-pushed
the
DKAN-4291-add-mysql-empty-rows-option
branch
from
a501f86 to
c7fc297
Compare
janette
requested changes
Oct 18, 2024
| @@ -7,6 +7,6 @@ To use, simply enable _datastore_mysql_import_ and clear your cache. | |||
|
|
|||
| ## Differences in behavior with the default DKAN importer. | |||
|
|
|||
| * Any "blank" rows in your data file, including carriage returns, will be imported into the datastore as empty rows. The default importer will ignore these rows. | |||
| * Any "blank" rows in your data file, including carriage returns, will be imported into the datastore as empty rows. The default importer ignores any blank rows. To have the Mysql Importer behave the same as default importer and ignore empty rows, enable the option on this page /admin/dkan/datastore/mysql_import | |||
There was a problem hiding this comment.
Can you add a "the" before default importer in the second sentence?
| mapping: | ||
| remove_empty_rows: | ||
| type: boolean | ||
| label: 'Remove empty rows in dataset' |
There was a problem hiding this comment.
More accurate to say 'Remove empty rows from the datastore table'
| @@ -0,0 +1,6 @@ | |||
| datastore_mysql_import.settings_form: | |||
| title: MySQl Import settings | |||
swirtSJW
commented
Oct 21, 2024
...les/datastore/modules/datastore_mysql_import/config/schema/datastore_mysql_import.schema.yml
Outdated
Show resolved
Hide resolved
modules/datastore/modules/datastore_mysql_import/datastore_mysql_import.links.menu.yml
Outdated
Show resolved
Hide resolved
janette
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4291
Describe your changes
QA Steps
ddev dkan-phpunit --group datastore_mysql_importChecklist before requesting review
If any of these are left unchecked, please provide an explanation