Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobStoreFactory determines table name #4063

Merged
merged 11 commits into from
Dec 8, 2023
Merged

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Nov 20, 2023

As part of an effort to decouple jobstore table names from implementation class names, we want the JobStoreFactory to determine table names. This will suport consistency in future changes to this system.

This PR:

  • Moves table name logic out of JobStore and into JobStoreFactory.
  • Replaces JobStoreAccessor with JobStoreFactoryAccessor to facilitate handling of deprecated jobstore table names.
  • Modifies JobStoreUtil to use JobStoreFactoryAccessor.
  • Adds and modifies tests to prove this all works.
  • Improves docblocks.

@paul-m paul-m marked this pull request as ready for review December 6, 2023 21:35
@dafeder dafeder merged commit ddd47ca into 2.x Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants