Create a search page using Drupal views #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
janette
changed the title
janette
force-pushed
the
metastore_search_view_2
branch
3 times, most recently
from
e19b60d
to
56b5977
Compare
dafeder
requested changes
Jan 24, 2024
| @@ -0,0 +1,34 @@ | |||
| { | |||
There was a problem hiding this comment.
We need this to be added to the DKAN composer.json, this won't get read be composer for a project
There was a problem hiding this comment.
This is an optional module that is available but not enabled by default, I think the follow up ticket is to create a second ddev site install command for a standing up a non-decoupled FE site. Or am I missing your point here?
| @@ -26,6 +26,11 @@ field_settings: | |||
| datasource_id: dkan_dataset | |||
| property_path: modified | |||
| type: string | |||
| nid: | |||
There was a problem hiding this comment.
I think we need an update hook to do the config import task automatically as well, you shouldn't have to run drush cim when you enable a module.
dafeder
reviewed
Jan 24, 2024
janette
force-pushed
the
metastore_search_view_2
branch
from
ddb4dde
to
a9d3af9
Compare
…ting the path for the new search page view
janette
force-pushed
the
metastore_search_view_2
branch
from
15e6fb1
to
d19d5da
Compare
dafeder
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA Steps
metastore_search_view_2branch in your local DKANNotes
This introduces a breaking change to the search api config so existing sites will need to import the config manually IF they have not altered the search api config. And if this feature is desired on a site that has modifications to the dkan search api, they will need to be reconciled first with the changes this branch is adding.