Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow select2 without entity reference (#4043) #4044

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Allow select2 without entity reference (#4043) #4044

merged 1 commit into from
Nov 6, 2023

Conversation

stefan-korn
Copy link
Contributor

fixes #4043

  • Test coverage exists
  • Documentation exists

QA Steps

  • Use select2 instead of select_other for license in dataset.ui.json
  • see that the select widget changes to select2 (providing search in select widget)

janette
janette approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@janette janette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @stefan-korn

@janette janette merged commit d80a091 into GetDKAN:2.x Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janette janette janette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow select2 without entity reference
2 participants
@stefan-korn @janette