FileFetcher should always reflect use-local-file config #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-m
changed the title
jastraat
reviewed
Oct 30, 2023
dafeder
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on GetDKAN/file-fetcher#32
Since
FileFetcheris anAbstractPersistentJob, any part of DKAN which creates aFileFetcherobject will end up persisting that object within the database.This means that if you were to check the status of a file being fetched (which will create a
FileFetcherobject), and then changed the configuration to always use local files, that configuration would be ignored on all subsequent calls to create aFileFetcherobject for that file.One solution to this would be to refactor the way such status items are checked. This requires a great deal of refactoring.
Instead, this PR subclasses
FileFetcherand allows for changing the way the file is fetched to reflect the runtime configuration.