Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16918: Correct configuration schema errors #4025

Merged
merged 3 commits into from
Sep 22, 2023
Merged

16918: Correct configuration schema errors #4025

merged 3 commits into from
Sep 22, 2023

Conversation

jastraat
Copy link
Contributor

@jastraat jastraat commented Sep 22, 2023

Currently both search_api.index.dkan and system.action.hide_current return schema errors when running the following check:

drush config:inspect --strict-validation

  • Test coverage exists
  • Documentation exists

QA Steps

  • Temporarily install the config_inspector contributed module
  • Run drush config:inspect --strict-validation and confirm no schema errors for DKAN-related configuration files.

@jastraat jastraat requested a review from paul-m September 22, 2023 14:30
Copy link
Contributor

@paul-m paul-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes generalize the views config, and only strengthen the schema for other configs.

@paul-m paul-m changed the title WCMS-16918: Correct configuration schema errors 16918: Correct configuration schema errors Sep 22, 2023
@paul-m paul-m merged commit 5ed06a4 into 2.x Sep 22, 2023
@paul-m paul-m deleted the config_schema branch September 22, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants