Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceLocalizer constructor arg should be an interface #4019

Merged
merged 2 commits into from
Sep 15, 2023
Merged

ResourceLocalizer constructor arg should be an interface #4019

merged 2 commits into from
Sep 15, 2023

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Sep 15, 2023 •
edited
Loading

One DKAN site uses a bespoke file fetcher for S3 localization.

Changes in #3996 broke this functionality, since we changed the signature of ResourceLocalizer::__construct().

This PR changes the signature back so it's \Contracts\FactoryInterface.

jastraat
jastraat approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with PDC, and this addressed the issues we were seeing with PDC's decorated Filefetcher factory. Thanks!

@dafeder dafeder merged commit 422da3a into 2.x Sep 15, 2023
@dafeder dafeder deleted the 16674-factory-interface branch September 15, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jastraat jastraat jastraat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-m @jastraat @dafeder