Import manager improvements #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight after data has been imported into the datastore.
janette
reviewed
Apr 26, 2019
| @@ -235,6 +245,7 @@ public function import() { | |||
| if ($import_state === self::DATA_IMPORT_DONE) { | |||
| $this->stateDataImport = self::DATA_IMPORT_DONE; | |||
| $this->saveState(); | |||
| module_invoke_all('datastore_post_import', $this->resource); | |||
There was a problem hiding this comment.
@dharizza do we still need this?
There was a problem hiding this comment.
Yes we do, because that's what will allow us to execute custom actions after a datastore import is completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If in a site we need to execute any steps right after the import to datastore process, right now we don't have an easy way to do it, so in this PR we are introducing a new hook. This hook is called hook_datastore_post_import and it is fired when an import process is completed.
Right now, the dkan datastore tables don't have a primary key field, which may lead to issues when someone needs to index the items from a datastore, so in this PR we're also altering the datastore table schema to include a serial
entry_idfield which will work as the primary key.QA Steps
entry_idas primary key.