Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading environments to PHP7, we've noticed that search facet items are being double-escape on characters like ampersands (&). Removing two different XSS filters we had added in fixes this, and we have not been able to reproduce any issues of XSS scripting vulnerability. This can be reversed if security scans detect a problem.
To reproduce
QA Steps
This also removes any licenses from the licenses facet that aren't defined in DKAN, so that we don't have ugly URLs in the facet (which lead to broken links anyway).