Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap_library module #2692

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Add bootstrap_library module #2692

merged 1 commit into from
Oct 11, 2018

Conversation

janette
Copy link
Member

@janette janette commented Oct 10, 2018

connects #2667

  • Using Bootstrap JS from CDN causes cross-domain javascript source file inclusion security errors.
  • Using bootstrap_library breaks recline and dropdown menu functionality.
  • Patching the radix theme to use a local bootstrap.min.js file.

QA Steps

@janette
Copy link
Member Author

janette commented Oct 10, 2018

taking this back, the menu drop downs stop working

@dafeder
Copy link
Member

dafeder commented Oct 11, 2018

@janette - the CDN is still being used on the probo site. I don't see anything that actually applies your patch to the radix theme on build.

@janette
Copy link
Member Author

janette commented Oct 11, 2018

sorry @dafeder fixed the make file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants