Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around for version check until the version strategy is determined #2637

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Work-around for version check until the version strategy is determined #2637

merged 2 commits into from
Sep 4, 2018

Conversation

janette
Copy link
Member

@janette janette commented Aug 22, 2018

Fixes #2537

QA

When on the Available Updates page, you should not see

* Warning: Invalid argument supplied for foreach() in theme_update_report() (line 53 of /var/www/docroot/modules/update/update.report.inc).
* Warning: sort() expects parameter 1 to be array, null given in theme_update_report() (line 182 of /var/www/docroot/modules/update/update.report.inc).
* Warning: implode(): Invalid arguments passed in theme_update_report() (line 193 of /var/www/docroot/modules/update/update.report.inc).

@dafeder
Copy link
Member

dafeder commented Aug 30, 2018

@janette I don't see the error messages you mention in the QA steps, but now I do see this after running cron and at the top of the module updates page:

Notice: Undefined index: dkan in dkan_sitewide_update_status_alter() (line 206 of /var/www/dkan/modules/dkan/dkan_sitewide/dkan_sitewide.module).

image

image

@dafeder
Copy link
Member

dafeder commented Aug 30, 2018

BTW the Pantheon install is still failing, but when I run the install locally I also get that error at the very end of the GUI install.

@dafeder dafeder merged commit b1f382f into GetDKAN:7.x-1.x Sep 4, 2018
dafeder pushed a commit that referenced this pull request Apr 24, 2020
#2637)

* Add check to see if  is not empty

* Revise check for current dkan version
dafeder pushed a commit that referenced this pull request Apr 24, 2020
#2637)

* Add check to see if  is not empty

* Revise check for current dkan version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants