Move functions out of .install #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimwdavidson it is in the code review lane and assigned to Aaron, is there something missing to indicate it is ready? |
|
Hmm, it's in progress on the waffle board. I'll move it over
…On Mon, Apr 23, 2018 at 6:09 PM, Janette Day ***@***.***> wrote:
@kimwdavidson <https://github.com/kimwdavidson> it is in the code review
lane and assigned to Aaron, is there something missing to indicate it is
ready?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2464 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVe-LMnbphJNmrA4Se2feaKrbDZpbuhAks5trlEbgaJpZM4TaIl4>
.
--
Kim Davidson
Project Manager | CivicActions <http://civicactions.com>
e: [email protected]
Skype: kwdavidson
|
|
weird, its been in review since last week for me |
|
Looks good to me. |
acouch
approved these changes
Apr 25, 2018
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to call the
_dkan_sitewide_menu_setup_admin_menu_source()when implementing custom permissions as it will also include menu links to additional admin pages. Currently the function is in the .install file, sofunction_exists('_dkan_sitewide_menu_setup_admin_menu_source')returns false, we can usemodule_load_install()or move functions out of the install file.connects https://github.com/NuCivic/ga_reports/issues/448