Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Add Content page and content types #2418

Merged
merged 2 commits into from
Jul 31, 2018

Conversation

stefaniefgray
Copy link

Cut out very wordy language; unnecessary "sales" type jargon.

Description. Please write any background information about this PR you think is useful for the product team. Use any of the items below that are relevant to this pull request, and delete any that are not.

User story

If this PR introduces new functionality, include a user story or stories describing what this pull request is intended for.

How to reproduce

  1. If the PR fixes a bug, include step-by-step instructions for reproducing the bug on a current DKAN release.

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

Merge process

  • Note if there is a special sequence for merging (such as PRs on other repos that need to be merged first) or other abnormalities to look out for.

Reminders

  • There is test for the issue.
  • CHANGELOG updated.
  • Coding standards checked.
  • Review docs.getdkan.com (or in /docs) to see if it still covers the scope of the PR and update if needed.

Cut out very wordy language; unnecessary "sales" type jargon.
@erogray erogray removed their assignment Apr 20, 2018
@erogray
Copy link

erogray commented Apr 20, 2018

Looks good from here.

@erogray
Copy link

erogray commented May 11, 2018

@janette can this be merged?

@janette
Copy link
Member

janette commented May 11, 2018

@erogray @stefaniefgray
No, the markup is really wonky, node type descriptions are in quote format, subheads are larger that headings, needs work.

wrong image for 'This image displays where you can enable grid, graph and/or map previews for a Resource.'

lets remove the animated gifs, these are pretty annoying

@erogray
Copy link

erogray commented May 11, 2018

Adding for my own future reference, since I didn't look before: https://docs.getdkan.com/en/latest/admin/data_and_content/adding_new_content.html

@kimwdavidson kimwdavidson added To Do and removed ready labels Jun 20, 2018
Previews are being wonky; trying to make sure my .rst formatting is decent
@stefaniefgray stefaniefgray merged commit a58fd94 into 7.x-1.x Jul 31, 2018
@fmizzell fmizzell deleted the stefaniefgray-docs-2 branch August 16, 2018 13:25
dafeder pushed a commit that referenced this pull request Apr 24, 2020
Updating Add Content page and content types
dafeder pushed a commit that referenced this pull request Apr 24, 2020
Updating Add Content page and content types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants