Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust group.editor.feature so we only create content when needed #2405

Merged
merged 7 commits into from
Apr 28, 2018

Conversation

janette
Copy link
Member

@janette janette commented Feb 26, 2018

Remove unnecessary creation of resources on scenarios that don't need them. Lets only create resources for the scenarios that need them.

circleci

@fmizzell
Copy link
Contributor

@janette The last time I was dealing with constraint violations was due to a silent failure before the failing test. Did you check on that? It would be odd on a resource due to the primary id being an nid which is an auto-increment, but still worth looking into.

@janette
Copy link
Member Author

janette commented Feb 27, 2018

@fmizzell Yes this is side stepping the real issue but does get us to green. I found this article which seemed worth looking into when we have some devops time https://knpuniversity.com/screencast/behat/clear-data-symfony-extension#clearing-the-database-before-each-scenario

And https://gist.github.com/cordoval/1206686#backgrounds

@janette
Copy link
Member Author

janette commented Mar 23, 2018

I think this is still an improvement as we avoid creating an unnecessary resources on 12 scenarios.

@fmizzell fmizzell removed their assignment Apr 13, 2018
@fmizzell fmizzell merged commit 5e575d4 into 7.x-1.x Apr 28, 2018
@fmizzell fmizzell deleted the group.editor branch June 7, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants