Updates docker-compose to use updated cli container (#2533)

* Updates to our own container * Updates enabling xdebug * Fixes artifacts * Updates config * Update config.yml
GetDKAN · Jun 5, 2018 · 61da527 · 61da527
1 parent 678312b
commit 61da527
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 29 deletions.
diff --git a/.ahoy/.docker/etc/php5/php-cli.ini b/.ahoy/.docker/etc/php5/php-cli.ini
diff --git a/.ahoy/docker-compose.common.yml b/.ahoy/docker-compose.common.yml
@@ -51,7 +51,7 @@ services:
   # Used for all console commands and tools.
   cli:
     hostname: cli
-    image: nuams/drupal-cli:2016-10-16
+    image: getdkan/dkan-docker:php5-cli
     environment:
       - XDEBUG_CONFIG=idekey=PHPSTORM
     env_file:
@@ -66,10 +66,6 @@ services:
     ports:
       - "8888"
     volumes:
-      # PHP configuration overrides
-      - "./.docker/etc/php5/php-cli.ini:/etc/php5/cli/conf.d/z_php.ini"
-      - "./.docker/etc/php5/xdebug-linux.ini:/etc/php5/xdebug-linux.ini"
-      - "./.docker/etc/php5/xdebug-macos.ini:/etc/php5/xdebug-macos.ini"
       # Host SSH keys mapping. Uncomment one of the lines below based on your setup.
       - ~/.ssh:/.ssh
     labels:

diff --git a/.ahoy/docker.ahoy.yml b/.ahoy/docker.ahoy.yml
@@ -336,13 +336,15 @@ commands:
       case $args in
         start)
         ahoy docker exec web cp -f ${XDEBUG_FILE} /etc/php5/mods-available/xdebug.ini
-        ahoy docker exec cli cp -f ${XDEBUG_FILE} /etc/php5/mods-available/xdebug.ini
+        ahoy docker exec cli phpenmod xdebug
+        ahoy docker exec cli cp -f ${XDEBUG_FILE} /etc/php/5.6/cli/conf.d/${XDEBUG_FILE}
         ahoy docker compose restart web
         ahoy docker compose restart cli
           ;;
         stop)
         ahoy docker exec web rm -f /etc/php5/mods-available/xdebug.ini
-        ahoy docker exec cli rm -f /etc/php5/mods-available/xdebug.ini
+        ahoy docker exec cli phpdismod xdebug
+        ahoy docker exec cli rm -f /etc/php5/mods-available/${XDEBUG_FILE}
         ahoy docker compose restart web
         ahoy docker compose restart cli
           ;;

diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -61,6 +61,9 @@ jobs:
           name: Setup DKAN
           command: |
             bash dkan-init.sh dkan --deps
+      - restore_cache:
+          keys:
+            - v1-dkan-test-vendor
       - run:
           name: Start containers
           command: |
@@ -71,7 +74,6 @@ jobs:
             docker cp .ahoy.yml $(docker-compose ps -q cli):/var/www
             mkdir -p dkan/test/assets/junit
             docker cp dkan $(docker-compose ps -q cli):/var/www
-            ahoy docker xdebug stop
       - run:
           name: Install Drupal
           command: |
@@ -95,12 +97,8 @@ jobs:
       - run:
           name: Install Test Libs
           command: |
-            ahoy cd-proxy bash dkan/.ahoy/.scripts/composer-install.sh docroot/profiles/dkan/test
-      - save_cache:
-          key: v1-dkan-{{ .Branch }}
-          paths:
-            - ~/.drush
-            - ~/.composer
+            ahoy cmd-proxy bash dkan/.ahoy/.scripts/composer-install.sh docroot/profiles/dkan/test
+            docker cp $(docker-compose ps -q cli):/var/www/dkan/test/vendor dkan/test/vendor
       - save_cache:
           key: v1-dkan-test-vendor
           paths:
@@ -110,6 +108,7 @@ jobs:
           command: ruby dkan/.ahoy/.scripts/circle-behat.rb docroot/profiles/dkan/test/features
       - run:
           name: Copy Assets to Base Image
+          when: on_fail
           command: |
             docker cp $(docker-compose ps -q cli):/var/www/dkan/test/assets assets
       - run: